Add handling of accept headers like application/hal+json #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let request predicates produce sth like application/*+json
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
============================================
+ Coverage 80.76% 81.14% +0.38%
- Complexity 122 124 +2
============================================
Files 15 16 +1
Lines 421 435 +14
Branches 85 93 +8
============================================
+ Hits 340 353 +13
- Misses 38 39 +1
Partials 43 43
Continue to review full report at Codecov.
|
ruibritopt
reviewed
Jun 25, 2019
| override fun supports(input: APIGatewayProxyRequestEvent): Boolean = | ||
| input.contentType() != null && MediaType.parse(input.contentType()).`is`(proto) | ||
| if (input.contentType() == null) | ||
| false |
Contributor
There was a problem hiding this comment.
I believe you are missing this test case. I was going to write it for you but I'm having that weird kotlin overload problem
| class MediaTypeTest { | ||
|
|
||
| @Test | ||
| fun `should match`() { |
Contributor
There was a problem hiding this comment.
Table Test, just a little bit, pretty please, sugar on top 😁 😁 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let request predicates produce sth like application/*+json